kscience/controls-kt
8
0
Fork 0
Code Issues Pull Requests 2 Packages Projects Releases 1 Wiki Activity

WIP: Composition of specifications and devices #13

Draft
kolpakov.mm wants to merge 3 commits from dev-maxim into dev
pull from: dev-maxim
merge into: kscience:dev
Conversation 3 Commits 3 Files Changed 14 +2190 -104
kolpakov.mm commented 2024-12-19 11:50:26 +03:00
Owner
Copy Link

Implemented builders for PropertyDescriptor and ActionDescriptor. Some typos have been fixed. Introduced a new hierarchical device structure based on CompositeDeviceSpec and ConfigurableCompositeDevice. They draw ideas from DeviceSpec and DeviceBySpec. This is a prototype implementation, and further refactoring is expected. The key feature is clear composition of device specifications for a declarative description of devices and their behavior. Moreover, the API for parent and child devices (specs) is the same.

Implemented builders for PropertyDescriptor and ActionDescriptor. Some typos have been fixed. Introduced a new hierarchical device structure based on CompositeDeviceSpec and ConfigurableCompositeDevice. They draw ideas from DeviceSpec and DeviceBySpec. This is a prototype implementation, and further refactoring is expected. The key feature is clear composition of device specifications for a declarative description of devices and their behavior. Moreover, the API for parent and child devices (specs) is the same.
kolpakov.mm added 2 commits 2024-12-19 11:50:27 +03:00
altavir commented 2024-12-19 11:52:49 +03:00
Owner
Copy Link

Please fix MR name to better reflect what it does.

Please fix MR name to better reflect what it does.
altavir self-assigned this 2024-12-19 11:52:55 +03:00
altavir requested review from altavir 2024-12-19 11:53:00 +03:00
altavir commented 2024-12-19 11:56:56 +03:00
Owner
Copy Link

Also please add examples of new API usage both in code and in MR description.

Also please add examples of new API usage both in code and in MR description.
kolpakov.mm changed title from WIP: dev-maxim to WIP: Composition of specifications and devices 2024-12-19 11:57:55 +03:00
kolpakov.mm added 1 commit 2024-12-19 12:12:12 +03:00
kolpakov.mm commented 2024-12-19 12:16:11 +03:00
Author
Owner
Copy Link

Added examples of new API usage - CompositeControlTest based on Analyzer device with subdevices. In specification, define "by childSpec" for passing child device specification. In device, define "by childDevice" for getting child device. For now not properly working, not all tests are passed.

Added examples of new API usage - CompositeControlTest based on Analyzer device with subdevices. In specification, define "by childSpec" for passing child device specification. In device, define "by childDevice" for getting child device. For now not properly working, not all tests are passed.
altavir added the due date 2024-12-26 2024-12-19 12:59:06 +03:00
This pull request is marked as a work in progress.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin dev-maxim:dev-maxim
git checkout dev-maxim
Sign in to join this conversation.
Reviewers
No reviewers
altavir
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

The issue awaits its hero. Contributions are welcome

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
altavir
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

2024-12-26

Dependencies

No dependencies set.

Reference: kscience/controls-kt#13
No description provided.
Delete Branch "dev-maxim"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?