kscience/visionforge
8
1
Fork 1
Code Issues Pull Requests Packages Projects Releases 3 Wiki Activity

New primitives #76

Merged
altavir merged 4 commits from teldufalsari/visionforge:teldufalsari/rootToSolid into dev 2023-10-10 08:16:50 +03:00
Conversation 1 Commits 4 Files Changed 3 +207
teldufalsari commented 2023-10-08 16:12:19 +03:00
Owner
Copy Link

Implementation of ROOT Geometry primitives TGeoCone and TGeoCtub for VisionForge

image

Implementation of ROOT Geometry primitives TGeoCone and TGeoCtub for VisionForge ![image](/attachments/c707e0ed-e692-4fc4-afd0-b0ecb12c11fe)
image.png
10 KiB
teldufalsari added 2 commits 2023-10-08 16:12:20 +03:00
teldufalsari requested review from altavir 2023-10-08 16:12:41 +03:00
altavir requested review from pklimai 2023-10-08 16:19:07 +03:00
altavir self-assigned this 2023-10-08 16:19:14 +03:00
altavir requested changes 2023-10-08 16:27:38 +03:00
altavir left a comment
Owner
Copy Link

I wonder if we should move primitives like this to the root module since they are too specialized. But we can do it later.

I wonder if we should move primitives like this to the root module since they are too specialized. But we can do it later.
visionforge-solid/src/commonMain/kotlin/space/kscience/visionforge/solid/CutTube.kt Outdated
@ -0,0 +133,4 @@
@VisionBuilder
public inline fun MutableVisionContainer<Solid>.cutTube(
altavir commented 2023-10-08 16:25:17 +03:00
Owner
Copy Link

Add documentation for parameters.

Add documentation for parameters.
altavir marked this conversation as resolved
altavir commented 2023-10-08 16:28:14 +03:00
Owner
Copy Link

Also please bring branch up to date with dev.

Also please bring branch up to date with dev.
teldufalsari added 2 commits 2023-10-08 17:10:08 +03:00
altavir removed review request for pklimai 2023-10-10 08:14:46 +03:00
altavir requested review from altavir 2023-10-10 08:14:48 +03:00
altavir approved these changes 2023-10-10 08:16:26 +03:00
altavir merged commit 1ebeefe01c into dev 2023-10-10 08:16:50 +03:00
altavir deleted branch teldufalsari/rootToSolid 2023-10-10 08:17:10 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
altavir
Labels
Clear labels   
bug

Something isn't working

  
discussion

   
documentation

documentation and examples

  
duplicate

This issue or pull request already exists

  
feature

New feature or request

  
fixed in dev

Fixed, but not released

  
gdml

   
good first issue

An issue awaits its hero. Contributions are welcome

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
discussion
documentation
duplicate
feature
fixed in dev
gdml
good first issue
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
altavir
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kscience/visionforge#76
No description provided.
Delete Branch "teldufalsari/visionforge:teldufalsari/rootToSolid"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?