OnDragg functionality added #7

2022-07-22T08:54:50+03:00

ArystanK commented

2022-07-22 08:54:50 +03:00

(Migrated from github.com)

Now users will be able to customize the drag behavior of the map

Lewik (Migrated from github.com) reviewed 2022-07-22 08:54:50 +03:00

altavir (Migrated from github.com) requested changes 2022-07-23 10:09:49 +03:00

maps-kt-compose/src/commonMain/kotlin/centre/sciprog/maps/compose/MapView.kt

						
				@ -17,6 +17,7 @@ data class MapViewConfig(

				    val onClick: MapViewPoint.() -> Unit = {},

				    val onViewChange: MapViewPoint.() -> Unit = {},

				    val onSelect: (GmcBox) -> Unit = {},

				    val onDrag: (MapViewPoint, MapViewPoint) -> Boolean = { _, _ -> true },

altavir (Migrated from github.com) commented

2022-07-23 10:07:19 +03:00

It is not clear, how it works, needs to be documented

maps-kt-core/src/commonMain/kotlin/centre/sciprog/maps/Utils.kt

						
				@ -0,0 +2,4 @@

				import kotlin.math.PI

				fun Double.toDegrees() = this * 180 / PI

altavir (Migrated from github.com) commented

2022-07-23 10:05:37 +03:00

This polutes the global name space. Sadly it is not acceptable for the library. Move to demo. In order to introduce something like this, we need to limit it to a scope, or introduce value classes for radians or degrees.

altavir commented

2022-08-04 17:35:16 +03:00

(Migrated from github.com)

@ArystanK Please do not close pull requests, instead add commits to relevant branches and re-request code review. PRs are updated automatically from branches.