kscience/maps-kt
8
0
Fork 0
Code Issues Pull Requests 3 Packages Projects Releases 1 Wiki Activity

immutable_features #24

Merged
altavir merged 7 commits from immutable_features into dev 2024-07-08 11:56:05 +03:00
Conversation 2 Commits 7 Files Changed 21 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5da7ee7944 - Show all commits

2
maps-kt-features/src/commonMain/kotlin/space/kscience/maps/compose/canvasControls.kt
View File

@ -36,7 +36,7 @@ public fun <T : Any> Modifier.canvasControls(
val point = state.space.ViewPoint(coordinates, zoom) val point = state.space.ViewPoint(coordinates, zoom)
if (event.type == PointerEventType.Move) { if (event.type == PointerEventType.Move) {
features.forEachWithAttribute(HoverListenerAttribute) { id, feature, listeners -> features.forEachWithAttribute(HoverListenerAttribute) { _, feature, listeners ->
altavir marked this conversation as resolved Outdated
InsanusMokrassar commented 2024-07-08 10:47:22 +03:00
Outdated
Review
Copy Link

Does id argument is really needed here?

Does `id` argument is really needed here?
altavir commented 2024-07-08 11:53:14 +03:00
Outdated
Review
Copy Link

It should be ref and no, it is probably not needed.

It should be ref and no, it is probably not needed.
if (point in feature as DomainFeature) { if (point in feature as DomainFeature) {
listeners.forEach { it.handle(event, point) } listeners.forEach { it.handle(event, point) }
return@forEachWithAttribute return@forEachWithAttribute