kscience/maps-kt
7
0
Fork 0
Code Issues Pull Requests 3 Packages Projects Releases 1 Wiki Activity

immutable_features #24

Merged
altavir merged 7 commits from immutable_features into dev 2024-07-08 11:56:05 +03:00
Conversation 2 Commits 7 Files Changed 21 +561 -467
altavir commented 2024-07-08 09:16:47 +03:00
Owner
Copy Link
  • Replace compose-based snapshot maps. Features now could be decoupled from compose.
  • Add rate limiter for feature updates.
* Replace compose-based snapshot maps. Features now could be decoupled from compose. * Add rate limiter for feature updates.
altavir added 3 commits 2024-07-08 09:16:48 +03:00
altavir requested review from InsanusMokrassar 2024-07-08 09:16:59 +03:00
InsanusMokrassar added 1 commit 2024-07-08 11:04:05 +03:00
altavir commented 2024-07-08 11:14:41 +03:00
Author
Owner
Copy Link

@InsanusMokrassar I don't think I like your modification. The code duplication is very small. It does not warrant additional class in a public API. By the way, caching is probably not necessary for SVG export. It is done rarely.

@InsanusMokrassar I don't think I like your modification. The code duplication is very small. It does not warrant additional class in a public API. By the way, caching is probably not necessary for SVG export. It is done rarely.
InsanusMokrassar reviewed 2024-07-08 11:27:18 +03:00
maps-kt-features/src/commonMain/kotlin/space/kscience/maps/compose/canvasControls.kt Outdated
@ -37,3 +37,3 @@
if (event.type == PointerEventType.Move) {
features.forEachWithAttribute(HoverListenerAttribute) { _, feature, listeners ->
features.forEachWithAttribute(HoverListenerAttribute) { id, feature, listeners ->
InsanusMokrassar commented 2024-07-08 10:47:22 +03:00
Owner
Copy Link

Does id argument is really needed here?

Does `id` argument is really needed here?
altavir commented 2024-07-08 11:53:14 +03:00
Author
Owner
Copy Link

It should be ref and no, it is probably not needed.

It should be ref and no, it is probably not needed.
altavir marked this conversation as resolved
InsanusMokrassar added 1 commit 2024-07-08 11:29:49 +03:00 
This reverts commit bf128a3eb9.
InsanusMokrassar commented 2024-07-08 11:30:03 +03:00
Owner
Copy Link

@InsanusMokrassar I don't think I like your modification. The code duplication is very small. It does not warrant additional class in a public API. By the way, caching is probably not necessary for SVG export. It is done rarely.

Reverted

> @InsanusMokrassar I don't think I like your modification. The code duplication is very small. It does not warrant additional class in a public API. By the way, caching is probably not necessary for SVG export. It is done rarely. Reverted
InsanusMokrassar approved these changes 2024-07-08 11:41:46 +03:00
altavir added 2 commits 2024-07-08 11:55:26 +03:00
altavir merged commit e913874ace into dev 2024-07-08 11:56:05 +03:00
altavir deleted branch immutable_features 2024-07-08 11:56:05 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
InsanusMokrassar
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
fixed in dev

Fixed in dev branch

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
fixed in dev
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kscience/maps-kt#24
No description provided.
Delete Branch "immutable_features"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?