Added function to draw custom markers with Kotlin DSL Canvas API #1

2022-07-16T11:59:35+03:00

ArystanK commented

2022-07-16 11:59:35 +03:00

(Migrated from github.com)

FetureId can be extended to hold info about a feature??? I added unused onFeatureClick, which can be latter implemented with pointer input, where it will check coordinates with offset? Features need to hold info about their coordinates?

altavir commented

2022-07-16 12:29:04 +03:00

(Migrated from github.com)

Feature could contain any additional data, including the callback, but in my opinion it should be handled outside of the map itself. Map handles some callbacks like onClick (implemented), onPan (TODO) and onSelect(also TODO).

Feature could contain any additional data, including the callback, but in my opinion it should be handled outside of the map itself. Map handles some callbacks like `onClick` (implemented), `onPan` (TODO) and `onSelect`(also TODO).

Lewik commented

2022-07-16 13:01:42 +03:00

(Migrated from github.com)

Custom MapFeature (not just access) with access to Canvas - nice idea, never thought about it.
As I think - MapFeature should holds graphical information only. Without any additional data. User should receive FeatureId and find additional data by himself.

I don't think MapFeature.onClick is good idea, we should leave MapView callback only. That onClick is not about graphic.

btw, we should have simple access to canvas too. Without MapFeature wrapping

Custom MapFeature (not just access) with access to Canvas - nice idea, never thought about it. As I think - MapFeature should holds graphical information only. Without any additional data. User should receive FeatureId and find additional data by himself. I don't think MapFeature.onClick is good idea, we should leave MapView callback only. That onClick is not about graphic. btw, we should have simple access to canvas too. Without MapFeature wrapping

Lewik (Migrated from github.com) approved these changes 2022-07-16 13:17:31 +03:00

altavir commented

2022-07-16 14:25:20 +03:00

(Migrated from github.com)

@ArystanK Ping me when it is ready to be merged.