kscience/kmath
8
0
Fork 1
Code Issues Pull Requests 6 Packages Projects Releases 16 Wiki Activity

Fix #532 by making ShapeND a non-value class #522

Merged
altavir merged 1 commits from bug/defaultStridesCache into dev 2024-05-09 09:16:53 +03:00
Conversation 0 Commits 1 Files Changed 21 +92 -83
lounres commented 2024-05-08 22:03:22 +03:00
Owner
Copy Link
  • Make ShapeND a usual non-value class.
  • Implement ShapeND's its equals and hashCode methods. Deprecate contentEquals and contentHashCode.
- Make `ShapeND` a usual non-value class. - Implement `ShapeND`'s its `equals` and `hashCode` methods. Deprecate `contentEquals` and `contentHashCode`.
lounres added the
performance
 label 2024-05-08 22:03:22 +03:00
lounres self-assigned this 2024-05-08 22:03:22 +03:00
lounres added 1 commit 2024-05-08 22:03:22 +03:00
lounres requested review from altavir 2024-05-08 22:03:26 +03:00
altavir approved these changes 2024-05-09 09:16:29 +03:00
altavir merged commit 1881feb5e2 into dev 2024-05-09 09:16:53 +03:00
altavir deleted branch bug/defaultStridesCache 2024-05-09 09:16:53 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
altavir
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
discussion

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
feature

A new feature request

  
good first issue

The issue awaits its hero. Contributions are welcome

  
misc

Infrastructure tasks, cosmetic changes and miscellaneous tasks

  
performance

Performance optimization issue

  
question

Further information is requested

  
test

Add tests for some functionality

  
use case

A use case for library or feature

  
wontfix

This will not be worked on

No Label
bug
dependencies
discussion
documentation
duplicate
feature
good first issue
misc
performance
question
test
use case
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
lounres
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kscience/kmath#522
No description provided.
Delete Branch "bug/defaultStridesCache"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?