kscience/kmath
9
0
Fork 1
Code Issues Pull Requests 6 Packages Projects Releases 16 Wiki Activity

Added Levenberg-Marquardt algorithm and svd Golub-Kahan #513

Merged
margarita0303 merged 35 commits from dev into dev 2023-06-19 16:11:59 +03:00
Conversation 2 Commits 35 Files Changed 16 +1781 -18
margarita0303 commented 2023-05-07 21:37:27 +03:00 (Migrated from github.com)
Copy Link
No description provided.
grinisrit (Migrated from github.com) reviewed 2023-05-07 21:37:27 +03:00
spc-code requested changes 2023-05-09 20:32:16 +03:00
spc-code left a comment
Contributor
Copy Link

The main addition is a huge function that does not seem to require access to the algebra internals. I think it should be moved to a separate file as an extension. Also naming and parameter passing needs some work.

The main addition is a huge function that does not seem to require access to the algebra internals. I think it should be moved to a separate file as an extension. Also naming and parameter passing needs some work.
CommanderTvis (Migrated from github.com) requested changes 2023-05-18 09:16:47 +03:00
CommanderTvis (Migrated from github.com) left a comment
Copy Link

I am unfamiliar with the algorithms, so only coding conventions were reported.

I am unfamiliar with the algorithms, so only coding conventions were reported.
spc-code commented 2023-05-27 10:29:36 +03:00
Contributor
Copy Link

@margarita0303 You need to address all questions, bring the branch up to date with dev and re-request review.

@margarita0303 You need to address all questions, bring the branch up to date with dev and re-request review.
margarita0303 (Migrated from github.com) reviewed 2023-06-07 15:25:00 +03:00
margarita0303 (Migrated from github.com) reviewed 2023-06-07 15:25:10 +03:00
margarita0303 (Migrated from github.com) reviewed 2023-06-07 15:25:28 +03:00
margarita0303 (Migrated from github.com) reviewed 2023-06-07 15:25:37 +03:00
margarita0303 (Migrated from github.com) reviewed 2023-06-07 15:25:44 +03:00
margarita0303 (Migrated from github.com) reviewed 2023-06-07 15:25:56 +03:00
margarita0303 (Migrated from github.com) reviewed 2023-06-07 15:26:02 +03:00
margarita0303 (Migrated from github.com) reviewed 2023-06-07 15:26:14 +03:00
margarita0303 (Migrated from github.com) reviewed 2023-06-07 15:26:21 +03:00
margarita0303 (Migrated from github.com) reviewed 2023-06-07 15:26:27 +03:00
spc-code approved these changes 2023-06-11 08:55:50 +03:00
spc-code left a comment
Contributor
Copy Link

Some changes (especially in naming must be done, but they could be done post-merge

Some changes (especially in naming must be done, but they could be done post-merge
spc-code commented 2023-06-13 14:20:09 +03:00
Contributor
Copy Link

@grinisrit @CommanderTvis

@grinisrit @CommanderTvis
CommanderTvis (Migrated from github.com) approved these changes 2023-06-16 13:46:06 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
spc-code
grinisrit
CommanderTvis
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
discussion

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
feature

A new feature request

  
good first issue

The issue awaits its hero. Contributions are welcome

  
misc

Infrastructure tasks, cosmetic changes and miscellaneous tasks

  
performance

Performance optimization issue

  
question

Further information is requested

  
test

Add tests for some functionality

  
use case

A use case for library or feature

  
wontfix

This will not be worked on

No Label
bug
dependencies
discussion
documentation
duplicate
feature
good first issue
misc
performance
question
test
use case
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kscience/kmath#513
No description provided.
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?