kscience/kmath
8
0
Fork 1
Code Issues Pull Requests 6 Packages Projects Releases 16 Wiki Activity

Prototype of generic complex numbers #355

Closed
CommanderTvis wants to merge 1 commits from commandertvis/generic-complex into dev
pull from: commandertvis/generic-complex
merge into: kscience:dev
Conversation 1 Commits 1 Files Changed 35 +917 -788
CommanderTvis commented 2021-05-28 10:01:11 +03:00 (Migrated from github.com)
Copy Link
No description provided.
altavir (Migrated from github.com) reviewed 2021-05-28 10:01:11 +03:00
altavir commented 2021-05-28 10:11:59 +03:00 (Migrated from github.com)
Copy Link

I still do not see motivation for generic Complex numbers. @CommanderTvis @grinisrit . Please create an issue and provide the use-case. You need to keep in mind that we can always easily add new types like TwoComponenInt. Right now, I think that generalizing Complex number won't bring a lot to the feature list, but will complicate development and create new problems for performance and discoverability.

I still do not see motivation for generic Complex numbers. @CommanderTvis @grinisrit . Please create an issue and provide the use-case. You need to keep in mind that we can always easily add new types like `TwoComponenInt`. Right now, I think that generalizing Complex number won't bring a lot to the feature list, but will complicate development and create new problems for performance and discoverability.
grinisrit (Migrated from github.com) requested changes 2021-07-30 10:11:31 +03:00
grinisrit (Migrated from github.com) left a comment
Copy Link

create DoubleComplex , FloatComplex etc.

create `DoubleComplex` , `FloatComplex` etc.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
altavir
grinisrit
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
discussion

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
feature

A new feature request

  
good first issue

The issue awaits its hero. Contributions are welcome

  
misc

Infrastructure tasks, cosmetic changes and miscellaneous tasks

  
performance

Performance optimization issue

  
question

Further information is requested

  
test

Add tests for some functionality

  
use case

A use case for library or feature

  
wontfix

This will not be worked on

No Label
bug
dependencies
discussion
documentation
duplicate
feature
good first issue
misc
performance
question
test
use case
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kscience/kmath#355
No description provided.
Delete Branch "commandertvis/generic-complex"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?