kscience/kmath
9
0
Fork 1
Code Issues Pull Requests 6 Packages Projects Releases 16 Wiki Activity

Refactor/histograms #203

Merged
altavir merged 6 commits from refactor/histograms into dev 2021-02-18 18:05:04 +03:00
Conversation 0 Commits 6 Files Changed 23 +533 -422
altavir commented 2021-02-12 22:44:47 +03:00 (Migrated from github.com)
Copy Link
No description provided.
Zelenyy (Migrated from github.com) reviewed 2021-02-15 12:19:09 +03:00
kmath-histograms/src/commonMain/kotlin/kscience/kmath/histogram/Counters.kt
@ -19,1 +19,3 @@
public fun add(d: Double)
public class IntCounter : Counter<Int> {
private val innerValue = atomic(0)
Zelenyy (Migrated from github.com) commented 2021-02-15 12:19:09 +03:00
Copy Link

Why not inline class?

Why not inline class?
altavir (Migrated from github.com) reviewed 2021-02-15 12:24:35 +03:00
kmath-histograms/src/commonMain/kotlin/kscience/kmath/histogram/Counters.kt
@ -19,1 +19,3 @@
public fun add(d: Double)
public class IntCounter : Counter<Int> {
private val innerValue = atomic(0)
altavir (Migrated from github.com) commented 2021-02-15 12:24:35 +03:00
Copy Link

It is an interface. Atomics should not be exposed to the outside world. Also, inlining does not give anything here.

It is an interface. Atomics should not be exposed to the outside world. Also, inlining does not give anything here.
Zelenyy (Migrated from github.com) approved these changes 2021-02-18 17:54:53 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
Zelenyy
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
discussion

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
feature

A new feature request

  
good first issue

The issue awaits its hero. Contributions are welcome

  
misc

Infrastructure tasks, cosmetic changes and miscellaneous tasks

  
performance

Performance optimization issue

  
question

Further information is requested

  
test

Add tests for some functionality

  
use case

A use case for library or feature

  
wontfix

This will not be worked on

No Label
bug
dependencies
discussion
documentation
duplicate
feature
good first issue
misc
performance
question
test
use case
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kscience/kmath#203
No description provided.
Delete Branch "refactor/histograms"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?