kscience/kmath
8
0
Fork 1
Code Issues Pull Requests 6 Packages Projects Releases 16 Wiki Activity

Add fast quaternion implementation, minor changes to complex #156

Merged
CommanderTvis merged 40 commits from feature/quaternion into dev 2021-02-11 11:01:30 +03:00
Conversation 3 Commits 40 Files Changed 41 +570 -350
CommanderTvis commented 2020-10-27 14:07:56 +03:00 (Migrated from github.com)
Copy Link

closes #155

closes #155
CommanderTvis commented 2020-10-27 14:08:25 +03:00 (Migrated from github.com)
Copy Link

This PR currently lacks tests, also complex . quaternion operations are needed

This PR currently lacks tests, also complex . quaternion operations are needed
altavir (Migrated from github.com) reviewed 2021-01-05 16:57:40 +03:00
altavir (Migrated from github.com) left a comment
Copy Link

Maybe move complex and quaternion to a separate module, say kmath-complex? It would help to maintain proper stability guarantees. I am not sure about that, but it does not make a lot of sense to keep them in the core.

Maybe move complex and quaternion to a separate module, say `kmath-complex`? It would help to maintain proper stability guarantees. I am not sure about that, but it does not make a lot of sense to keep them in the core.
altavir commented 2021-01-19 15:11:07 +03:00 (Migrated from github.com)
Copy Link

Update plugin version to 0.7.3-1.4.30-RC to fix tests.

Update plugin version to `0.7.3-1.4.30-RC` to fix tests.
altavir commented 2021-01-19 19:39:53 +03:00 (Migrated from github.com)
Copy Link

Please resolve conflicts

Please resolve conflicts
altavir (Migrated from github.com) requested changes 2021-02-08 19:53:32 +03:00
altavir (Migrated from github.com) left a comment
Copy Link

Looks good. Only small changes are in order.

Looks good. Only small changes are in order.
examples/src/main/kotlin/kscience/kmath/operations/ComplexDemo.kt
altavir (Migrated from github.com) commented 2021-02-08 19:09:11 +03:00
Copy Link

Revert to more readable with please

Revert to more readable `with` please
kmath-complex/src/commonMain/kotlin/kscience/kmath/complex/Complex.kt
@ -0,0 +41,4 @@
get() = atan(im / re)
private val PI_DIV_2 = Complex(PI / 2, 0)
altavir (Migrated from github.com) commented 2021-02-08 19:13:46 +03:00
Copy Link

Lazy will be much more expensive here than an assignment. I do not think that there is a difference, but probably better to keep it simple.

Lazy will be much more expensive here than an assignment. I do not think that there is a difference, but probably better to keep it simple.
kmath-core/build.gradle.kts
altavir (Migrated from github.com) commented 2021-02-08 19:52:45 +03:00
Copy Link

Move appropriate tests to kmath-complex and remove the dependency.

Move appropriate tests to kmath-complex and remove the dependency.
altavir (Migrated from github.com) approved these changes 2021-02-11 11:01:20 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
altavir
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
discussion

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
feature

A new feature request

  
good first issue

The issue awaits its hero. Contributions are welcome

  
misc

Infrastructure tasks, cosmetic changes and miscellaneous tasks

  
performance

Performance optimization issue

  
question

Further information is requested

  
test

Add tests for some functionality

  
use case

A use case for library or feature

  
wontfix

This will not be worked on

No Label
bug
dependencies
discussion
documentation
duplicate
feature
good first issue
misc
performance
question
test
use case
wontfix
Milestone
Clear milestone
No items
No Milestone
0.2
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kscience/kmath#156
No description provided.
Delete Branch "feature/quaternion"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?