kscience/kmath
9
0
Fork 1
Code Issues Pull Requests 6 Packages Projects Releases 16 Wiki Activity

Add adapters of scalar functions to MST and vice versa #150

Merged
CommanderTvis merged 23 commits from kotlingrad into dev 2020-11-01 21:09:45 +03:00
Conversation 2 Commits 23 Files Changed 25 +508 -155
CommanderTvis commented 2020-10-12 16:27:16 +03:00 (Migrated from github.com)
Copy Link

closes #149

closes #149
CommanderTvis commented 2020-10-12 16:33:28 +03:00 (Migrated from github.com)
Copy Link

$ ping @breandan

$ ping @breandan
altavir commented 2020-10-12 17:04:43 +03:00 (Migrated from github.com)
Copy Link

Please add tests and at least some documentation. Also an example in examples would be welcome.

Please add tests and at least some documentation. Also an example in `examples` would be welcome.
altavir (Migrated from github.com) reviewed 2020-10-13 15:36:56 +03:00
kmath-ast-kotlingrad/src/main/kotlin/kscience/kmath/ast/kotlingrad/ScalarsAdapters.kt
altavir (Migrated from github.com) commented 2020-10-13 15:36:56 +03:00
Copy Link

change to toMst()

change to toMst()
altavir (Migrated from github.com) reviewed 2020-10-13 15:37:57 +03:00
settings.gradle.kts
altavir (Migrated from github.com) commented 2020-10-13 15:37:57 +03:00
Copy Link

I think simple kmath-kotlingrad is appropriate

I think simple kmath-kotlingrad is appropriate
altavir (Migrated from github.com) approved these changes 2020-11-01 12:13:06 +03:00
build.gradle.kts
@ -15,3 +23,4 @@
mavenCentral()
}
group = "kscience.kmath"
altavir (Migrated from github.com) commented 2020-11-01 12:04:44 +03:00
Copy Link

I do not like jitpack dependency here as well as other custom dependencies. You'd better move it to specific projects and explicitly list them in README both for the module and for examples.

I do not like jitpack dependency here as well as other custom dependencies. You'd better move it to specific projects and explicitly list them in README both for the module and for examples.
examples/build.gradle.kts
@ -11,3 +12,3 @@
repositories {
maven("https://dl.bintray.com/mipt-npm/kscience")
jcenter()
altavir (Migrated from github.com) commented 2020-11-01 12:05:25 +03:00
Copy Link

See the comment above. I think it makes sense to leave them here for people to see which repositories to use.

See the comment above. I think it makes sense to leave them here for people to see which repositories to use.
kmath-kotlingrad/src/test/kotlin/kscience/kmath/kotlingrad/AdaptingTests.kt
@ -0,0 +34,4 @@
@Test
fun simpleFunctionShape() {
val linear = "2*x+16".parseMath().toSFun<KMathNumber<Double, RealField>>()
if (linear !is Sum) fail()
altavir (Migrated from github.com) commented 2020-11-01 12:12:39 +03:00
Copy Link

Better to use AssertFalse

Better to use AssertFalse
CommanderTvis (Migrated from github.com) reviewed 2020-11-01 13:41:02 +03:00
kmath-kotlingrad/src/test/kotlin/kscience/kmath/kotlingrad/AdaptingTests.kt
@ -0,0 +34,4 @@
@Test
fun simpleFunctionShape() {
val linear = "2*x+16".parseMath().toSFun<KMathNumber<Double, RealField>>()
if (linear !is Sum) fail()
CommanderTvis (Migrated from github.com) commented 2020-11-01 13:41:01 +03:00
Copy Link

No. fail is better since it returns Nothing, so Kotlin DFA makes smart-cast of linear to Sum

No. `fail` is better since it returns Nothing, so Kotlin DFA makes smart-cast of `linear` to `Sum`
Sign in to join this conversation.
Reviewers
No reviewers
altavir
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
discussion

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
feature

A new feature request

  
good first issue

The issue awaits its hero. Contributions are welcome

  
misc

Infrastructure tasks, cosmetic changes and miscellaneous tasks

  
performance

Performance optimization issue

  
question

Further information is requested

  
test

Add tests for some functionality

  
use case

A use case for library or feature

  
wontfix

This will not be worked on

No Label
bug
dependencies
discussion
documentation
duplicate
feature
good first issue
misc
performance
question
test
use case
wontfix
Milestone
Clear milestone
No items
No Milestone
0.2
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kscience/kmath#150
No description provided.
Delete Branch "kotlingrad"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?