kscience/kmath
9
0
Fork 1
Code Issues Pull Requests 6 Packages Projects Releases 16 Wiki Activity

Add function contracts and perform some refactoring #130

Merged
CommanderTvis merged 4 commits from refactor-and-contracts into dev 2020-08-22 12:57:32 +03:00
Conversation 0 Commits 4 Files Changed 89 +780 -839
CommanderTvis commented 2020-08-21 22:48:16 +03:00 (Migrated from github.com)
Copy Link

Provide contracts for many functions, make inline several functions, replace <algebra>.run { and with(<algebra>) { with <algebra> {, add newlines at EOFs, specify operator modifier explicitly at many places, reformat files, replace if (...) error guards with require and check.

Provide contracts for many functions, make `inline` several functions, `replace <algebra>.run {` and `with(<algebra>) {` with `<algebra> {`, add newlines at EOFs, specify operator modifier explicitly at many places, reformat files, replace `if (...) error` guards with `require` and `check`.
altavir (Migrated from github.com) approved these changes 2020-08-22 08:29:19 +03:00
kmath-commons/src/main/kotlin/scientifik/kmath/commons/linear/CMMatrix.kt
altavir (Migrated from github.com) commented 2020-08-22 08:20:31 +03:00
Copy Link

What is the reason for that? It is not that I object...

What is the reason for that? It is not that I object...
kmath-core/src/commonMain/kotlin/scientifik/kmath/linear/FeaturedMatrix.kt
altavir (Migrated from github.com) commented 2020-08-22 08:23:16 +03:00
Copy Link

I think it makes sense to add Opt-in to the build instead of million-billion additional opt-in linse

I think it makes sense to add Opt-in to the build instead of million-billion additional opt-in linse
CommanderTvis (Migrated from github.com) reviewed 2020-08-22 11:21:00 +03:00
kmath-commons/src/main/kotlin/scientifik/kmath/commons/linear/CMMatrix.kt
CommanderTvis (Migrated from github.com) commented 2020-08-22 11:21:00 +03:00
Copy Link

Since this list is not empty or 1-element, Kotlin actually will construct LinkedHashSet to keep order of elements, which is slower.

Since this list is not empty or 1-element, Kotlin actually will construct LinkedHashSet to keep order of elements, which is slower.
CommanderTvis (Migrated from github.com) reviewed 2020-08-22 11:21:32 +03:00
kmath-core/src/commonMain/kotlin/scientifik/kmath/linear/FeaturedMatrix.kt
CommanderTvis (Migrated from github.com) commented 2020-08-22 11:21:31 +03:00
Copy Link

How?

How?
Sign in to join this conversation.
Reviewers
No reviewers
altavir
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
discussion

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
feature

A new feature request

  
good first issue

The issue awaits its hero. Contributions are welcome

  
misc

Infrastructure tasks, cosmetic changes and miscellaneous tasks

  
performance

Performance optimization issue

  
question

Further information is requested

  
test

Add tests for some functionality

  
use case

A use case for library or feature

  
wontfix

This will not be worked on

No Label
bug
dependencies
discussion
documentation
duplicate
feature
good first issue
misc
performance
question
test
use case
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kscience/kmath#130
No description provided.
Delete Branch "refactor-and-contracts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?