kscience/kmath
9
0
Fork 1
Code Issues Pull Requests 6 Packages Projects Releases 16 Wiki Activity

Extend mathematic operations support in the kmath-ast parser #120

Merged
CommanderTvis merged 10 commits from extended-grammar into dev 2020-07-27 19:37:09 +03:00
Conversation 1 Commits 10 Files Changed 10 +224 -64
CommanderTvis commented 2020-07-20 23:44:01 +03:00 (Migrated from github.com)
Copy Link
  • Add reference ANTLR grammar.
  • Add symbols support in ASM MST matcher.
  • Extend parser to support singular values (like i in ComplexField) as well as unary and binary functions.

closes #117

- Add reference ANTLR grammar. - Add symbols support in ASM MST matcher. - Extend parser to support singular values (like i in ComplexField) as well as unary and binary functions. closes #117
CommanderTvis commented 2020-07-27 10:36:20 +03:00 (Migrated from github.com)
Copy Link

Converting it to draft because of better-parse bug. h0tk3y/better-parse#28

Converting it to draft because of better-parse bug. h0tk3y/better-parse#28
Shimuuar (Migrated from github.com) reviewed 2020-07-27 11:09:53 +03:00
kmath-ast/reference/ArithmeticsEvaluator.g4
Shimuuar (Migrated from github.com) commented 2020-07-27 11:02:43 +03:00
Copy Link

1.23e+3 generally + in exponent is generally allowed

`1.23e+3` generally + in exponent is generally allowed
kmath-ast/reference/ArithmeticsEvaluator.g4
@ -0,0 +1,59 @@
grammar ArithmeticsEvaluator;
fragment DIGIT: '0'..'9';
fragment LETTER: 'a'..'z';
Shimuuar (Migrated from github.com) commented 2020-07-27 11:02:15 +03:00
Copy Link

What about uppercase letters?

What about uppercase letters?
kmath-ast/reference/ArithmeticsEvaluator.g4
@ -0,0 +50,4 @@
: powChain ((DIV | MUL) powChain)*
;
subSumChain
Shimuuar (Migrated from github.com) commented 2020-07-27 11:08:02 +03:00
Copy Link

Is operator precedence right? Looks suspicious. It would be nice to add test for it

Is operator precedence right? Looks suspicious. It would be nice to add test for it
CommanderTvis (Migrated from github.com) reviewed 2020-07-27 16:51:20 +03:00
kmath-ast/reference/ArithmeticsEvaluator.g4
@ -0,0 +50,4 @@
: powChain ((DIV | MUL) powChain)*
;
subSumChain
CommanderTvis (Migrated from github.com) commented 2020-07-27 16:51:20 +03:00
Copy Link

Tests were added

Tests were added
CommanderTvis (Migrated from github.com) reviewed 2020-07-27 16:51:45 +03:00
kmath-ast/reference/ArithmeticsEvaluator.g4
CommanderTvis (Migrated from github.com) commented 2020-07-27 16:51:45 +03:00
Copy Link

Fixed

Fixed
CommanderTvis (Migrated from github.com) reviewed 2020-07-27 16:51:54 +03:00
kmath-ast/reference/ArithmeticsEvaluator.g4
@ -0,0 +1,59 @@
grammar ArithmeticsEvaluator;
fragment DIGIT: '0'..'9';
fragment LETTER: 'a'..'z';
CommanderTvis (Migrated from github.com) commented 2020-07-27 16:51:53 +03:00
Copy Link

Added.

Added.
altavir (Migrated from github.com) approved these changes 2020-07-27 19:36:49 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
altavir
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
discussion

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
feature

A new feature request

  
good first issue

The issue awaits its hero. Contributions are welcome

  
misc

Infrastructure tasks, cosmetic changes and miscellaneous tasks

  
performance

Performance optimization issue

  
question

Further information is requested

  
test

Add tests for some functionality

  
use case

A use case for library or feature

  
wontfix

This will not be worked on

No Label
bug
dependencies
discussion
documentation
duplicate
feature
good first issue
misc
performance
question
test
use case
wontfix
Milestone
Clear milestone
No items
No Milestone
0.1.x
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kscience/kmath#120
No description provided.
Delete Branch "extended-grammar"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?