kscience/kmath
8
0
Fork 1
Code Issues Pull Requests 6 Packages Projects Releases 16 Wiki Activity

Implement kmath-nd4j: module that implements NDStructure for INDArray of ND4J #116

Merged
CommanderTvis merged 50 commits from nd4j into dev 2020-10-29 19:58:53 +03:00
Conversation 2 Commits 50 Files Changed 19 +852 -78
CommanderTvis commented 2020-06-27 17:02:37 +03:00 (Migrated from github.com)
Copy Link

closes #52

closes #52
altavir commented 2020-10-01 20:47:39 +03:00 (Migrated from github.com)
Copy Link

Please resolve conflicts

Please resolve conflicts
CommanderTvis commented 2020-10-01 21:25:13 +03:00 (Migrated from github.com)
Copy Link

@altavir

@altavir
altavir (Migrated from github.com) approved these changes 2020-10-29 09:27:49 +03:00
altavir (Migrated from github.com) left a comment
Copy Link

Looks nice. Is it possible to provide a test where ND4J structures are used alongside regular Real/Buffered NDAlgebra elements?

Looks nice. Is it possible to provide a test where ND4J structures are used alongside regular Real/Buffered NDAlgebra elements?
kmath-nd4j/src/main/kotlin/kscience.kmath.nd4j/INDArrayAlgebra.kt
altavir (Migrated from github.com) commented 2020-10-29 09:20:21 +03:00
Copy Link

I do not like naming. Could we use Nd4jArrayAlgebra etc?

I do not like naming. Could we use `Nd4jArrayAlgebra` etc?
CommanderTvis (Migrated from github.com) reviewed 2020-10-29 09:30:31 +03:00
kmath-nd4j/src/main/kotlin/kscience.kmath.nd4j/INDArrayAlgebra.kt
CommanderTvis (Migrated from github.com) commented 2020-10-29 09:30:31 +03:00
Copy Link

Yes

Yes
CommanderTvis (Migrated from github.com) reviewed 2020-10-29 09:30:48 +03:00
kmath-nd4j/src/main/kotlin/kscience.kmath.nd4j/INDArrayAlgebra.kt
CommanderTvis (Migrated from github.com) commented 2020-10-29 09:30:47 +03:00
Copy Link

It is 5 minutes to refactor.

It is 5 minutes to refactor.
altavir (Migrated from github.com) approved these changes 2020-10-29 19:57:09 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
altavir
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
discussion

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
feature

A new feature request

  
good first issue

The issue awaits its hero. Contributions are welcome

  
misc

Infrastructure tasks, cosmetic changes and miscellaneous tasks

  
performance

Performance optimization issue

  
question

Further information is requested

  
test

Add tests for some functionality

  
use case

A use case for library or feature

  
wontfix

This will not be worked on

No Label
bug
dependencies
discussion
documentation
duplicate
feature
good first issue
misc
performance
question
test
use case
wontfix
Milestone
Clear milestone
No items
No Milestone
0.2
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kscience/kmath#116
No description provided.
Delete Branch "nd4j"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?