kscience/gradle-tools
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 9 Wiki Activity

Refactor: explicit API, publishing extension, code style #28

Merged
CommanderTvis merged 1 commits from commandertvis/fix-publish into dev 2021-09-12 10:09:33 +03:00
Conversation 0 Commits 1 Files Changed 16 +308 -301
CommanderTvis commented 2021-08-11 13:13:46 +03:00 (Migrated from github.com)
Copy Link
No description provided.
altavir (Migrated from github.com) requested changes 2021-08-25 14:38:57 +03:00
src/main/kotlin/ru/mipt/npm/gradle/KScienceCommonPlugin.kt
altavir (Migrated from github.com) commented 2021-08-25 14:36:22 +03:00
Copy Link

This will fail if the extension does not exist. This construct is used for a reason

This will fail if the extension does not exist. This construct is used for a reason
src/main/kotlin/ru/mipt/npm/gradle/KScienceCommonPlugin.kt
altavir (Migrated from github.com) commented 2021-08-25 14:36:39 +03:00
Copy Link

For some reason it was not working before

For some reason it was not working before
src/main/kotlin/ru/mipt/npm/gradle/internal/fx.kt
altavir (Migrated from github.com) commented 2021-08-25 14:38:22 +03:00
Copy Link

See coment above

See coment above
CommanderTvis (Migrated from github.com) reviewed 2021-08-25 16:57:33 +03:00
src/main/kotlin/ru/mipt/npm/gradle/KScienceCommonPlugin.kt
CommanderTvis (Migrated from github.com) commented 2021-08-25 16:57:32 +03:00
Copy Link

Got it.

Got it.
CommanderTvis (Migrated from github.com) reviewed 2021-08-25 16:57:56 +03:00
src/main/kotlin/ru/mipt/npm/gradle/KScienceCommonPlugin.kt
CommanderTvis (Migrated from github.com) commented 2021-08-25 16:57:56 +03:00
Copy Link

🤔

🤔
altavir (Migrated from github.com) approved these changes 2021-09-12 10:09:28 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
altavir
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
feature

A new feature request

  
misc

Infrastructure tasks, cosmetic changes and miscellaneous tasks

  
question

Further information is requested

  
waiting for a hero

The issue awaits its hero. Contributions are welcome

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
feature
misc
question
waiting for a hero
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kscience/gradle-tools#28
No description provided.
Delete Branch "commandertvis/fix-publish"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?