teldufalsari/kmath
2
0
Fork 0
forked from kscience/kmath
Code Pull Requests 1 Activity

minor corrections to linear stuff

Browse Source
This commit is contained in:
Roland Grinis 2021-04-09 08:29:08 +01:00
parent 8c1131dd58
commit 5d8b42da90
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kmath-tensors/src/commonMain/kotlin/space/kscience/kmath/tensors/core/DoubleLinearOpsTensorAlgebra.kt
View File

@ -67,6 +67,7 @@ public class DoubleLinearOpsTensorAlgebra :
}
override fun DoubleTensor.cholesky(): DoubleTensor {
//positive definite check
checkSymmetric(this)
checkSquareMatrix(shape)
@ -114,8 +115,7 @@ public class DoubleLinearOpsTensorAlgebra :
override fun DoubleTensor.symEig(eigenvectors: Boolean): Pair<DoubleTensor, DoubleTensor> {
checkSymmetric(this)
val svd = this.svd()
TODO("U might have some columns negative to V")
TODO("maybe use SVD")
}
public fun DoubleTensor.detLU(): DoubleTensor {