teldufalsari/kmath
2
0
Fork 0
forked from kscience/kmath
Code Pull Requests 1 Activity

Fixed forgotten TODOs

Browse Source
This commit is contained in:
Gleb Minaev 2022-03-14 14:18:15 +03:00
parent de53d032af
commit 07f4b83722
1 changed files with 45 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
kmath-functions/src/commonMain/kotlin/space/kscience/kmath/functions/RationalFunction.kt
View File

@ -105,34 +105,58 @@ public class RationalFunctionSpace<C, A : Ring<C>> (
* *
* The operation is equivalent to adding [this] copies of unit polynomial to [other]. * The operation is equivalent to adding [this] copies of unit polynomial to [other].
*/ */
public override operator fun Int.plus(other: RationalFunction<C>): RationalFunction<C> = TODO() public override operator fun Int.plus(other: RationalFunction<C>): RationalFunction<C> =
RationalFunction(
other.denominator * this + other.numerator,
other.denominator
)
/** /**
* Returns difference between the integer represented as rational function and the rational function. * Returns difference between the integer represented as rational function and the rational function.
* *
* The operation is equivalent to subtraction [this] copies of unit polynomial from [other]. * The operation is equivalent to subtraction [this] copies of unit polynomial from [other].
*/ */
public override operator fun Int.minus(other: RationalFunction<C>): RationalFunction<C> = TODO() public override operator fun Int.minus(other: RationalFunction<C>): RationalFunction<C> =
RationalFunction(
other.denominator * this - other.numerator,
other.denominator
)
/** /**
* Returns product of the integer represented as rational function and the rational function. * Returns product of the integer represented as rational function and the rational function.
* *
* The operation is equivalent to sum of [this] copies of [other]. * The operation is equivalent to sum of [this] copies of [other].
*/ */
public override operator fun Int.times(other: RationalFunction<C>): RationalFunction<C> = TODO() public override operator fun Int.times(other: RationalFunction<C>): RationalFunction<C> =
RationalFunction(
this * other.numerator,
other.denominator
)
// endregion // endregion
// region Constant-rational relation // region Constant-rational relation
/** /**
* Returns sum of the constant represented as rational function and the rational function. * Returns sum of the constant represented as rational function and the rational function.
*/ */
public override operator fun C.plus(other: RationalFunction<C>): RationalFunction<C> = TODO() public override operator fun C.plus(other: RationalFunction<C>): RationalFunction<C> =
RationalFunction(
other.denominator * this + other.numerator,
other.denominator
)
/** /**
* Returns difference between the constant represented as polynomial and the rational function. * Returns difference between the constant represented as polynomial and the rational function.
*/ */
public override operator fun C.minus(other: RationalFunction<C>): RationalFunction<C> = TODO() public override operator fun C.minus(other: RationalFunction<C>): RationalFunction<C> =
RationalFunction(
other.denominator * this - other.numerator,
other.denominator
)
/** /**
* Returns product of the constant represented as polynomial and the rational function. * Returns product of the constant represented as polynomial and the rational function.
*/ */
public override operator fun C.times(other: RationalFunction<C>): RationalFunction<C> = TODO() public override operator fun C.times(other: RationalFunction<C>): RationalFunction<C> =
RationalFunction(
this * other.numerator,
other.denominator
)
// endregion // endregion
// region Rational-constant relation // region Rational-constant relation
@ -166,15 +190,27 @@ public class RationalFunctionSpace<C, A : Ring<C>> (
/** /**
* Returns sum of the polynomial represented as rational function and the rational function. * Returns sum of the polynomial represented as rational function and the rational function.
*/ */
public override operator fun Polynomial<C>.plus(other: RationalFunction<C>): RationalFunction<C> = TODO() public override operator fun Polynomial<C>.plus(other: RationalFunction<C>): RationalFunction<C> =
RationalFunction(
other.denominator * this + other.numerator,
other.denominator
)
/** /**
* Returns difference between the polynomial represented as polynomial and the rational function. * Returns difference between the polynomial represented as polynomial and the rational function.
*/ */
public override operator fun Polynomial<C>.minus(other: RationalFunction<C>): RationalFunction<C> = TODO() public override operator fun Polynomial<C>.minus(other: RationalFunction<C>): RationalFunction<C> =
RationalFunction(
other.denominator * this - other.numerator,
other.denominator
)
/** /**
* Returns product of the polynomial represented as polynomial and the rational function. * Returns product of the polynomial represented as polynomial and the rational function.
*/ */
public override operator fun Polynomial<C>.times(other: RationalFunction<C>): RationalFunction<C> = TODO() public override operator fun Polynomial<C>.times(other: RationalFunction<C>): RationalFunction<C> =
RationalFunction(
this * other.numerator,
other.denominator
)
// endregion // endregion
// region Rational-polynomial relation // region Rational-polynomial relation