kscience/kmath
9
0
Fork 1
Code Issues Pull Requests 6 Packages Projects Releases 16 Wiki Activity

QR + test #263

Merged
AndreiKingsley merged 9 commits from andrew into feature/tensor-algebra 2021-03-30 18:58:24 +03:00
Conversation 0 Commits 9 Files Changed 3 +2 -6
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 139534fdb3 - Show all commits

8
kmath-core/src/commonMain/kotlin/space/kscience/kmath/tensors/core/DoubleLinearOpsTensorAlgebra.kt
View File

@ -183,11 +183,7 @@ public class DoubleLinearOpsTensorAlgebra :
} }
private fun MutableStructure1D<Double>.l2Norm(): Double { private fun MutableStructure1D<Double>.l2Norm(): Double {
var squareSum = 0.0 return sqrt((0 until size).sumOf { this[it] * this[it] })
for (i in 0 until size) {
squareSum += this[i] * this[i]
}
return sqrt(squareSum)
} }
fun qrHelper( fun qrHelper(
@ -223,7 +219,7 @@ public class DoubleLinearOpsTensorAlgebra :
val (q, r) = qr val (q, r) = qr
qrHelper(matrix.as2D(), q.as2D(), r.as2D()) qrHelper(matrix.as2D(), q.as2D(), r.as2D())
} }
return Pair(qTensor, rTensor) return qTensor to rTensor
} }
override fun DoubleTensor.svd(): Triple<DoubleTensor, DoubleTensor, DoubleTensor> { override fun DoubleTensor.svd(): Triple<DoubleTensor, DoubleTensor, DoubleTensor> {