Changes for upcoming GSL extension project #148

Merged
CommanderTvis merged 98 commits from gsl-experiment into dev 2021-02-19 13:34:27 +03:00
3 changed files with 15 additions and 13 deletions
Showing only changes of commit 8f6163698c - Show all commits

View File

@ -29,10 +29,10 @@ jobs:
path: |
~/.konan/dependencies
~/.konan/kotlin-native-prebuilt-linux-1.4.20-eap-37
key: ${{ runner.os }}-konan-1.4.0
restore-keys: ${{ runner.os }}-konan-1.4.0
key: ${{ runner.os }}-konan-1.4.20-eap-37
restore-keys: ${{ runner.os }}-konan-1.4.20-eap-37
- name: Build with Gradle
run: ./gradlew -Dorg.gradle.daemon=false --build-cache :kmath-gsl:cinteropLibgslNative build
run: ./gradlew -Dorg.gradle.daemon=false --build-cache :kmath-gsl:cinteropLibgslLinuxX64 build
build-osx:
runs-on: macos-latest
@ -59,7 +59,7 @@ jobs:
path: |
~/.konan/dependencies
~/.konan/kotlin-native-prebuilt-macos-1.4.20-eap-37
key: ${{ runner.os }}-konan-1.4.0
restore-keys: ${{ runner.os }}-konan-1.4.0
key: ${{ runner.os }}-konan-1.4.20-eap-37
restore-keys: ${{ runner.os }}-konan-1.4.20-eap-37
- name: Build with Gradle
run: ./gradlew -Dorg.gradle.daemon=false --build-cache :kmath-gsl:cinteropLibgslNative build
run: ./gradlew -Dorg.gradle.daemon=false --build-cache :kmath-gsl:cinteropLibgslMacosX64 build

View File

@ -1,9 +1,7 @@
kotlin.code.style=official
kotlin.parallel.tasks.in.project=true
kotlin.mpp.enableGranularSourceSetsMetadata=true
kotlin.native.enableDependencyPropagation=false
kotlin.mpp.stability.nowarn=true
kotlin.parallel.tasks.in.project=true
org.gradle.jvmargs=-XX:MaxMetaspaceSize=512m
org.gradle.parallel=true
systemProp.org.gradle.internal.publish.checksums.insecure=true
systemProp.org.gradle.internal.publish.checksums.insecure=true

View File

@ -12,7 +12,11 @@ import org.gnu.gsl.gsl_matrix_equal
altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions
import org.gnu.gsl.gsl_matrix_get
public sealed class GslMatrix<T : Any> : FeaturedMatrix<T> {
public abstract val nativeHandle: CValues<out CStructVar>
altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions
protected abstract val nativeHandle: CValues<out CStructVar>
altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions
altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions
override fun equals(other: Any?): Boolean {
altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions
return NDStructure.equals(this, other as? NDStructure<*> ?: return false)
altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions
}
altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions
public override fun hashCode(): Int {
var result = nativeHandle.hashCode()
@ -21,7 +25,7 @@ public sealed class GslMatrix<T : Any> : FeaturedMatrix<T> {
altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions
}
}
public class GslRealMatrix(public override val nativeHandle: CValues<gsl_matrix>, features: Set<MatrixFeature>) :
altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions
public class GslRealMatrix(protected override val nativeHandle: CValues<gsl_matrix>, features: Set<MatrixFeature>) :
altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions
GslMatrix<Double>() {
public override val rowNum: Int
@ -42,6 +46,6 @@ public class GslRealMatrix(public override val nativeHandle: CValues<gsl_matrix>
altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions
public override fun equals(other: Any?): Boolean {
if (other is GslRealMatrix) gsl_matrix_equal(nativeHandle, other.nativeHandle)
return NDStructure.equals(this, other as? NDStructure<*> ?: return false)
altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions
return super.equals(other)
altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions
}
}

altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
altavir commented 2020-10-04 09:11:08 +03:00 (Migrated from github.com)
Review

handle should probably be private

handle should probably be private
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:04 +03:00 (Migrated from github.com)
Review

That's true, but the current challenge is to build this at least

That's true, but the current challenge is to build this at least
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions
CommanderTvis commented 2020-10-04 09:18:29 +03:00 (Migrated from github.com)
Review

Currently, I can't even run cinterop in Actions

Currently, I can't even run cinterop in Actions