From 730678b2fc5aaba5ad3b3fba32fc77ae4b72f160 Mon Sep 17 00:00:00 2001
From: Alexander Nozik <altavir@gmail.com>
Date: Sun, 31 Jan 2021 20:02:11 +0300
Subject: [PATCH] Add safety checks for kmath-for-real buffer operations.

---
 .../kotlin/kscience/kmath/real/RealVector.kt  | 24 ++++++++++++-------
 1 file changed, 16 insertions(+), 8 deletions(-)

diff --git a/kmath-for-real/src/commonMain/kotlin/kscience/kmath/real/RealVector.kt b/kmath-for-real/src/commonMain/kotlin/kscience/kmath/real/RealVector.kt
index 596692782..ee2a960a1 100644
--- a/kmath-for-real/src/commonMain/kotlin/kscience/kmath/real/RealVector.kt
+++ b/kmath-for-real/src/commonMain/kotlin/kscience/kmath/real/RealVector.kt
@@ -29,8 +29,10 @@ public inline fun RealVector.map(transform: (Double) -> Double): RealVector =
 public inline fun RealVector.mapIndexed(transform: (index: Int, value: Double) -> Double): RealVector =
     Buffer.real(size) { transform(it, get(it)) }
 
-public operator fun RealVector.plus(other: RealVector): RealVector =
-    mapIndexed { index, value -> value + other[index] }
+public operator fun RealVector.plus(other: RealVector): RealVector {
+    require(size == other.size){"Vector size $size expected but ${other.size} found"}
+    return mapIndexed { index, value -> value + other[index] }
+}
 
 public operator fun RealVector.plus(number: Number): RealVector = map { it + number.toDouble() }
 
@@ -38,22 +40,28 @@ public operator fun Number.plus(vector: RealVector): RealVector = vector + this
 
 public operator fun RealVector.unaryMinus(): Buffer<Double> = map { -it }
 
-public operator fun RealVector.minus(other: RealVector): RealVector =
-    mapIndexed { index, value -> value - other[index] }
+public operator fun RealVector.minus(other: RealVector): RealVector {
+    require(size == other.size){"Vector size $size expected but ${other.size} found"}
+    return mapIndexed { index, value -> value - other[index] }
+}
 
 public operator fun RealVector.minus(number: Number): RealVector = map { it - number.toDouble() }
 
 public operator fun Number.minus(vector: RealVector): RealVector = vector.map { toDouble() - it }
 
-public operator fun RealVector.times(other: RealVector): RealVector =
-    mapIndexed { index, value -> value * other[index] }
+public operator fun RealVector.times(other: RealVector): RealVector {
+    require(size == other.size){"Vector size $size expected but ${other.size} found"}
+    return mapIndexed { index, value -> value * other[index] }
+}
 
 public operator fun RealVector.times(number: Number): RealVector = map { it * number.toDouble() }
 
 public operator fun Number.times(vector: RealVector): RealVector = vector * this
 
-public operator fun RealVector.div(other: RealVector): RealVector =
-    mapIndexed { index, value -> value / other[index] }
+public operator fun RealVector.div(other: RealVector): RealVector {
+    require(size == other.size){"Vector size $size expected but ${other.size} found"}
+    return mapIndexed { index, value -> value / other[index] }
+}
 
 public operator fun RealVector.div(number: Number): RealVector = map { it / number.toDouble() }