minor corrections to linear stuff

2021-04-09 08:29:08 +01:00 · 2021-04-09 08:29:08 +01:00 · 5d8b42da90
commit 5d8b42da90
parent 8c1131dd58
1 changed files with 2 additions and 2 deletions
--- a/kmath-tensors/src/commonMain/kotlin/space/kscience/kmath/tensors/core/DoubleLinearOpsTensorAlgebra.kt
+++ b/kmath-tensors/src/commonMain/kotlin/space/kscience/kmath/tensors/core/DoubleLinearOpsTensorAlgebra.kt
@ -67,6 +67,7 @@ public class DoubleLinearOpsTensorAlgebra :
    }

    override fun DoubleTensor.cholesky(): DoubleTensor {
+        //positive definite check
        checkSymmetric(this)
        checkSquareMatrix(shape)

@ -114,8 +115,7 @@ public class DoubleLinearOpsTensorAlgebra :

    override fun DoubleTensor.symEig(eigenvectors: Boolean): Pair<DoubleTensor, DoubleTensor> {
        checkSymmetric(this)
-        val svd = this.svd()
-        TODO("U might have some columns negative to V")
+        TODO("maybe use SVD")
    }

    public fun DoubleTensor.detLU(): DoubleTensor {