Call remote tasks of service workspace #75

Closed
winter-yuki wants to merge 25 commits from winter-yuki/distributed into 0.6
2 changed files with 54 additions and 19 deletions
Showing only changes of commit e9d4683f9b - Show all commits

View File

@ -29,7 +29,7 @@ internal class RemoteTask<T : Any>(
winter-yuki commented 2022-05-01 10:24:32 +03:00 (Migrated from github.com)
Review

Use ConnectionPool

Use `ConnectionPool`
winter-yuki commented 2022-05-01 10:24:32 +03:00 (Migrated from github.com)
Review

Use ConnectionPool

Use `ConnectionPool`
altavir commented 2022-05-04 18:23:28 +03:00 (Migrated from github.com)
Review

Is it possible to avoid the cast? For example specialize output for this workspace?

Is it possible to avoid the cast? For example specialize output for this workspace?
altavir commented 2022-05-04 18:23:28 +03:00 (Migrated from github.com)
Review

Is it possible to avoid the cast? For example specialize output for this workspace?

Is it possible to avoid the cast? For example specialize output for this workspace?
taskName: Name,
taskMeta: Meta,
): TaskResult<T> = withContext(dispatcher) {
val dataset = ServiceWorkspace.execute(taskName) as LazyDecodableDataSet
winter-yuki commented 2022-05-01 10:24:32 +03:00 (Migrated from github.com)
Review

Use ConnectionPool

Use `ConnectionPool`
altavir commented 2022-05-04 18:23:28 +03:00 (Migrated from github.com)
Review

Is it possible to avoid the cast? For example specialize output for this workspace?

Is it possible to avoid the cast? For example specialize output for this workspace?
val dataset = ServiceWorkspace.execute(taskName)
winter-yuki commented 2022-05-01 10:24:32 +03:00 (Migrated from github.com)
Review

Use ConnectionPool

Use `ConnectionPool`
altavir commented 2022-05-04 18:23:28 +03:00 (Migrated from github.com)
Review

Is it possible to avoid the cast? For example specialize output for this workspace?

Is it possible to avoid the cast? For example specialize output for this workspace?
dataset.finishDecoding(resultType)
workspace.wrapResult(dataset as DataSet<T>, taskName, taskMeta)
}

winter-yuki commented 2022-05-01 10:24:32 +03:00 (Migrated from github.com)
Review

Use ConnectionPool

Use `ConnectionPool`
winter-yuki commented 2022-05-01 10:24:32 +03:00 (Migrated from github.com)
Review

Use ConnectionPool

Use `ConnectionPool`
altavir commented 2022-05-04 18:23:28 +03:00 (Migrated from github.com)
Review

Is it possible to avoid the cast? For example specialize output for this workspace?

Is it possible to avoid the cast? For example specialize output for this workspace?
altavir commented 2022-05-04 18:23:28 +03:00 (Migrated from github.com)
Review

Is it possible to avoid the cast? For example specialize output for this workspace?

Is it possible to avoid the cast? For example specialize output for this workspace?

View File

@ -19,6 +19,7 @@ import kotlinx.coroutines.flow.asFlow
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
import kotlinx.coroutines.flow.map
import kotlinx.coroutines.flow.toList
import kotlinx.coroutines.runBlocking
import kotlinx.serialization.KSerializer
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
import kotlinx.serialization.Serializable
import kotlinx.serialization.json.Json
import kotlinx.serialization.serializer
@ -34,6 +35,7 @@ import space.kscience.dataforge.data.await
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
import space.kscience.dataforge.data.component1
import space.kscience.dataforge.data.component2
import space.kscience.dataforge.meta.Meta
import space.kscience.dataforge.meta.MetaSerializer
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
import space.kscience.dataforge.names.Name
import space.kscience.dataforge.names.asName
import space.kscience.dataforge.workspace.Task
@ -60,7 +62,10 @@ public class ServiceWorkspace(
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
get() = context.gather(Task.TYPE)
private val service = LibService(serviceId, address, port) {
execute of { name -> println("service = $name"); produce(name, Meta.EMPTY) } // TODO
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
execute of { name ->
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
val res = produce(name, Meta.EMPTY)
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
LazyDecodableDataSetAdapter(res)
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
}
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
}
/**
@ -108,12 +113,26 @@ private object NameCoder : Coder<Name> {
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
Entity(RawData.copyFrom(value.toString(), Charset.defaultCharset()))
}
@Serializable
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
private data class DataPrototype(
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
val meta: String,
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
val data: String,
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
) {
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
companion object {
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
suspend fun <T : Any> of(data: Data<T>, serializer: KSerializer<in T>): DataPrototype {
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
val meta = Json.encodeToString(MetaSerializer, data.meta)
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
val string = Json.encodeToString(serializer, data.await())
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
return DataPrototype(meta, string)
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
}
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
}
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
}
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
/**
* Data class that represents serializable [DataSet].
*/
@Serializable
private data class DataSetPrototype(
val data: Map<String, String>,
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
val data: Map<String, DataPrototype>,
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
)
/**
@ -121,9 +140,9 @@ private data class DataSetPrototype(
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
*/
private fun <T : Any> DataSet<T>.toPrototype(): DataSetPrototype = runBlocking {
val serializer = serializer(dataType)
val map = mutableListOf<Pair<String, String>>()
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
val map = mutableListOf<Pair<String, DataPrototype>>()
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
flowData().map { (name, data) ->
name.toString() to Json.encodeToString(serializer, data.await())
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
name.toString() to DataPrototype.of(data, serializer)
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
}.toList(map)
DataSetPrototype(map.associate { it })
}
@ -131,11 +150,14 @@ private fun <T : Any> DataSet<T>.toPrototype(): DataSetPrototype = runBlocking {
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
/**
* Trivial [Data] implementation.
*/
private class SimpleData(override val type: KType, val data: Any) : Data<Any> {
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
override val meta: Meta
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
get() = Meta.EMPTY
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
private class SimpleData(
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
override val type: KType,
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
override val meta: Meta,
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
val data: Any,
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
) : Data<Any> {
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
override val dependencies: Collection<Goal<*>>
get() = emptyList()
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
override val deferred: Deferred<Any>
get() = CompletableDeferred(data)
@ -158,43 +180,56 @@ internal interface LazyDecodableDataSet<T : Any> : DataSet<T> {
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
fun finishDecoding(type: KType)
}
private class LazyDecodableDataSetAdapter<T : Any>(val dataSet: DataSet<T>) :
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
LazyDecodableDataSet<T>, DataSet<T> by dataSet {
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
override fun finishDecoding(type: KType) = Unit
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
}
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
/**
* Trivial [LazyDecodableDataSet] implementation.
*/
private class SimpleDataSet(private val prototype: DataSetPrototype) : LazyDecodableDataSet<Any> {
lateinit var type: KType
lateinit var data: Map<Name, Any>
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
lateinit var data: Map<Name, Pair<Meta, Any>>
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
override fun finishDecoding(type: KType) {
this.type = type
this.data = prototype.data.map { (name, data) ->
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
Name.parse(name) to Json.decodeFromString(serializer(type), data)
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
}.associate { (name, data) -> name to data!! }
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
val serializer = serializer(type)
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
this.data = prototype.data
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
.mapKeys { (name, _) -> Name.of(name) }
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
.mapValues { (_, pair) ->
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
val (meta, data) = pair
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
Pair(
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
Json.decodeFromString(MetaSerializer, meta),
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
Json.decodeFromString(serializer, data)!!
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
)
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
}
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
}
override val dataType: KType
get() = type
override fun flowData(): Flow<NamedData<Any>> =
data.map { (name, data) ->
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
val wrapped = SimpleData(dataType, data)
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
data.map { (name, pair) ->
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
val (meta, data) = pair
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
val wrapped = SimpleData(dataType, meta, data)
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
SimpleNamedData(name, wrapped)
}.asFlow()
override suspend fun getData(name: Name): Data<Any>? = data[name]?.let { data ->
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
SimpleData(dataType, data)
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
override suspend fun getData(name: Name): Data<Any>? = data[name]?.let { (meta, data) ->
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
SimpleData(dataType, meta, data)
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
}
}
private object DataSetCoder : Coder<DataSet<Any>> {
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
override fun decode(entity: Entity, context: CodingContext): DataSet<Any> {
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
private object DataSetCoder : Coder<LazyDecodableDataSet<Any>> {
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
override fun decode(entity: Entity, context: CodingContext): LazyDecodableDataSet<Any> {
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
val string = entity.data.toString(Charset.defaultCharset())
val prototype = Json.decodeFromString(serializer<DataSetPrototype>(), string)
return SimpleDataSet(prototype)
}
override fun encode(value: DataSet<*>, context: CodingContext): Entity {
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
override fun encode(value: LazyDecodableDataSet<Any>, context: CodingContext): Entity {
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
val prototype = value.toPrototype()
val string = Json.encodeToString(serializer(), prototype)
return Entity(RawData.copyFrom(string, Charset.defaultCharset()))

winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
winter-yuki commented 2022-05-01 10:23:36 +03:00 (Migrated from github.com)
Review

Remove debug print

Remove debug print
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:33:41 +03:00 (Migrated from github.com)
Review

Better to pass Adress from outside instead of constructor initialization.

Better to pass Adress from outside instead of constructor initialization.
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:03 +03:00 (Migrated from github.com)
Review

Why?

Why?
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
altavir commented 2022-05-04 20:34:30 +03:00 (Migrated from github.com)
Review

There is existing one

There is existing one
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:37 +03:00 (Migrated from github.com)
Review

I think that may be not a good idea to expose lambdarpc dependency

I think that may be not a good idea to expose lambdarpc dependency
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:48:53 +03:00 (Migrated from github.com)
Review

Just temporary hole

Just temporary hole
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason
winter-yuki commented 2022-05-09 19:49:39 +03:00 (Migrated from github.com)
Review

Yes, but it is private for some reason

Yes, but it is private for some reason